FolderStatusModel: only create a single QFileIconProvider object #7899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsding
added
os: 🚪 Windows
feature: ☁️ GUI
|
/backport to stable-3.16 |
claucambra
requested changes
Feb 20, 2025
nilsding
force-pushed
the
bugfix/settingswindow-performance-improvement
branch
from
11e10c1 to
3f4a987
Compare
otherwise the icons will end up being loaded from the system each time, which on Windows takes quite long (I saw many calls to `shell32.dll!SHDefExtractIcon` during profiling) Signed-off-by: Jyrki Gadinger <[email protected]>
nilsding
force-pushed
the
bugfix/settingswindow-performance-improvement
branch
from
3f4a987 to
df4a8e9
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-7899.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise the icons will end up being loaded from the system each time, which on Windows takes quite long (I saw many calls to
shell32.dll!SHDefExtractIconduring profiling)Fixes #7372, tested on Win11, Linux, macOS