Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.16] UserStatusSelector: set focusPolicy on accept button #7907

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 21, 2025

Backport of PR #7906

otherwise the status text won't be set on macOS as the text box never
loses its focus

`Qt.StrongFocus` is the default focusPolicy on all platforms except for
macOS, there it's `Qt.TabFocus`

the other buttons of the UserStatusSelector don't need that focusPolicy
as they do not modify the model from values in the view

see also:
- https://bugreports.qt.io/browse/QTBUG-110295
- https://codebrowser.dev/qt6/qtdeclarative/src/quicktemplates/qquickabstractbutton.cpp.html#_ZN27QQuickAbstractButtonPrivate4initEv

Signed-off-by: Jyrki Gadinger <[email protected]>
@backportbot backportbot bot requested review from mgallien, Rello and nilsding February 21, 2025 10:44
@backportbot backportbot bot added this to the 3.16.0 milestone Feb 21, 2025
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-7907.zip

SHA256 checksum: ab2430483b0ad4e8b4a2ea0fbd888a447ad84852fb95fd38e8a38c0d2e85484f

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nilsding nilsding merged commit 2d0e585 into stable-3.16 Feb 21, 2025
14 of 16 checks passed
@nilsding nilsding deleted the backport/7906/stable-3.16 branch February 21, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants