Bugfix/slow bulk upload #8048
Open
Bugfix/slow bulk upload #8048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
requested review from
camilasan,
claucambra and
nilsding
as code owners
claucambra
requested changes
Mar 20, 2025
Comment on lines
+105
to
111
| if (oneDevice._device->isOpen()) { | ||
| if (!oneDevice._device->errorString().isEmpty()) { | ||
| qCWarning(lcPutMultiFileJob) << "oneDevice has error:" << oneDevice._device->errorString(); | ||
| } | ||
| } | ||
|
|
||
| if (oneDevice._device->isOpen()) { |
There was a problem hiding this comment.
Can't we condense this?
Suggested change
| if (oneDevice._device->isOpen()) { | |
| if (!oneDevice._device->errorString().isEmpty()) { | |
| qCWarning(lcPutMultiFileJob) << "oneDevice has error:" << oneDevice._device->errorString(); | |
| } | |
| } | |
| if (oneDevice._device->isOpen()) { | |
| if (oneDevice._device->isOpen()) { | |
| if (!oneDevice._device->errorString().isEmpty()) { | |
| qCWarning(lcPutMultiFileJob) << "oneDevice has error:" << oneDevice._device->errorString(); | |
| } |
Signed-off-by: Matthieu Gallien <[email protected]>
should help make it faster to send all data Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
bugfix/slowBulkUpload
branch
from
197bbc5 to
6316d84
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8048.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.