gui/macOS: Do not assume accountState will always be valid in socket controller #8053
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
added
os: 🍎 macOS
feature: 💽 virtual filesystem
feature: ☁️ GUI
claucambra
requested review from
camilasan,
mgallien and
nilsding
as code owners
nilsding
approved these changes
Mar 19, 2025
Signed-off-by: Claudio Cambra <[email protected]>
When removing an account this can change Signed-off-by: Claudio Cambra <[email protected]>
claucambra
force-pushed
the
work/dont-assume-valid-accountstate
branch
from
c561fe3 to
697c308
Compare
|
/backport to stable-3.16 |
|
Artifact containing the AppImage: nextcloud-appimage-pr-8053.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crash on account removal