WIP: chore: refactor migration functions. #8154
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilasan
force-pushed
the
bugfix/settingsmigration2
branch
from
389e785 to
da96d27
Compare
|
camilasan
force-pushed
the
bugfix/settingsmigration2
branch
3 times, most recently
from
85cf378 to
609910c
Compare
- First look for legacy locations and then try to restore general, proxy and accounts settings. - Functions handling account migration go into AccountManager and functions handling legacy config check go in ConfigFile. Signed-off-by: Camila Ayres <[email protected]>
The client was failing to pick up the config file. Signed-off-by: Camila Ayres <[email protected]>
- Separate logic from widgets. - Functions handling account migration go into AccountManager and functions handling legacy config check go in ConfigFile. Signed-off-by: Camila Ayres <[email protected]>
camilasan
force-pushed
the
bugfix/settingsmigration2
branch
2 times, most recently
from
47b336c to
1e65552
Compare
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
…iles. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
…egacy file. At that point we already know that the config file does not exist. Signed-off-by: Camila Ayres <[email protected]>
The same logic is already implemented in ConfigFile::findLegacyClientConfigFile. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
camilasan
force-pushed
the
bugfix/settingsmigration2
branch
from
848223a to
bdde6f2
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8154.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #8036.