Bugfix/version windows integration improve install #8178
Conversation
goal is to bump specifically this version number only when needed Signed-off-by: Matthieu Gallien <[email protected]>
shoudl enable replacing files during install happen only when needed instead of always will need to take care of migration from older releases Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
requested review from
camilasan,
claucambra and
nilsding
as code owners
mgallien
force-pushed
the
bugfix/versionWindowsIntegrationImproveInstall
branch
from
192e189 to
543cc4a
Compare
|
Artifact containing the AppImage: nextcloud-appimage-pr-8178.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
| @@ -45,7 +45,7 @@ | |||
| https://www.joyofsetup.com/2010/01/16/major-upgrades-now-easier-than-ever/ | |||
| --> | |||
| <MajorUpgrade Schedule="afterInstallInitialize" AllowDowngrades="yes" /> | |||
| <Property Id="REINSTALLMODE" Value="amus" /> | |||
| <Property Id="REINSTALLMODE" Value="omus" /> | |||
There was a problem hiding this comment.
hmm, I wonder if this shouldn't be dmus instead
if I understand the REINSTALLMODE flags correctly:
oreplaces files if they are an older version (might make downgrades difficult?)dreplaces files if the version is differentereplaces files if the version is the same as the current one or olderareplaces all files regardless
| @@ -7,6 +7,8 @@ set(MIRALL_VERSION_PATCH 50) | |||
| set(MIRALL_VERSION_YEAR 2025) | |||
| set(MIRALL_SOVERSION 0) | |||
| set(MIRALL_PREVERSION_HUMAN "3.17.0 alpha") # For preversions where PATCH>=50. Use version + alpha, rc1, rc2, etc. | |||
| set(WINDOWS_INTEGRATION_VERSION 4) | |||
| set(WINDOWS_INTEGRATION_SOVERSION 4) | |||
There was a problem hiding this comment.
where does the 4 come from?
NCExt/Version.h defines the NCEXT_BUILD_NUM constant with 47 that is part of the NCEXT_VERSION constant
and how does setting these as target properties differ from having it be defined in the .rc files? e.g.
desktop/shell_integration/windows/NCOverlays/NCOverlay.rc
Lines 67 to 68 in 3bdc2eb
|
No description provided.