-
Notifications
You must be signed in to change notification settings - Fork 890
User-defined File Provider Domain Name on macOS #8865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
faf6f8f to
68b1f98
Compare
Signed-off-by: Julian Thanner <[email protected]>
Signed-off-by: Julian Thanner <[email protected]>
|
Hello, thank you for this contribution. For any UI changes, also please provide screenshots |
i2h3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine for me so far. However, to retain or increase consistent terminology with the underlying technology, I would kindly ask to update symbol names to refer to "display names" instead of "folder names".
For reference, see this property on file provider domains:
https://developer.apple.com/documentation/fileprovider/nsfileproviderdomain/displayname
I won't approve on my own because I cannot comment on the Qt part. I need feedback from the others in that regard.
On this occasion, I understand the reason why the user defaults access is implemented redundantly in fileprovidersettingscontroller_mac.mm and fileproviderdomainmanager_mac.mm. I guess it is a matter of time that this comes back like a boomerang. 😁 Maybe outsource this into a dedicated facility to have a consolidated, single implementation? I started moving things for the mapping between account and file provider domain identifiers recently, too.
camilasan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also use conventional commits convention: https://www.conventionalcommits.org/en/v1.0.0/
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
No description provided.