feat: preserve the last selected account between runs

[DmySyz]

Description

Implements #8986 and #9035

This PR implements the feature to remember and restore the last selected account after the client restarts. Previously, the client would always select the first account on startup, which was frustrating for users with multiple accounts.

Changes Made

1. ConfigFile (src/libsync/configfile.h and configfile.cpp):

   • Added lastSelectedAccountC constant for the settings key
   • Added lastSelectedAccount() getter method
   • Added setLastSelectedAccount() setter method

2. UserModel (src/gui/tray/usermodel.cpp):

   • Modified buildUserList() to restore the last selected account on startup
   • Modified setCurrentUserId() to save the account id when user changes accounts
   • If the account written in the settings is unavailable - choses the first one (provided that it exists)

How It Works

• On account selection: When a user manually selects an account, the selection is saved to nextcloud.cfg
• On startup: buildUserList() attempts to restore the last selected account
• Fallback: If the saved account doesn't exist or the id was corrupted, it falls back to the first account

Technical Details

• Handles edge cases: deleted accounts, empty account lists, etc.

Testing

The fix has been manually tested. Unit test has not been added as an appropriate existing test for the relevant component was not found and creating it was deemed out of scope for this PR.

Screenshots

feat_preserve_acc.mp4

Notes

As account IDs are not randomly generated it is possible that a wrong account will be selected if somehow the original one was deleted and another one was created in its place outside the client.

[DmySyz]

Sorry, it seems I've borked my github setup (haven't used github in a long time).
Does someone know if it is possible to remove the merge commit with the github cli (gh)?

[i2h3]

Does someone know if it is possible to remove the merge commit with the github cli (gh)?

I do not know about gh but in Git it would be an git rebase --interactive on master in which the merge commit is just dropped then. 🤔

[DmySyz]

Does someone know if it is possible to remove the merge commit with the github cli (gh)?

I do not know about gh but in Git it would be an git rebase --interactive on master in which the merge commit is just dropped then. 🤔

Was overthinking it a bit 😅

[DmySyz]

@Aiiaiiio Seems you have been reviewing the previous attempt at implementing this thingy. Could you take a look at this one as well if you have some time?

[DmySyz]

Not entirely sure what is wrong with the SonarCloud check. If someone could clarify whether the issue is on my side, I'd be grateful 👍

[mgallien]

@DmySyz can you solve the conflicts ?
sorry that you have to do it

[DmySyz]

@DmySyz can you solve the conflicts ? sorry that you have to do it

No worries. Should be ok now

[Aiiaiiio]

Looks awesome! See my change request please. We can discuss if you disagree.

[DmySyz]

Not entirely sure what is wrong with the SonarCloud check. If someone could clarify whether the issue is on my side, I'd be grateful 👍

Still broken unfortunately.

"Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator to check the permissions of the user the token belongs to"

[DmySyz]

@Aiiaiiio sorry for dragging this thing on, but I think this version is the cleanest solution for now.
Could you take a look one more time? 😄

[Aiiaiiio]

I like it! Thank you!

[github-actions]

Artifact containing the AppImage: nextcloud-appimage-pr-9061.zip

Digest: sha256:2d88c86a3feccb1086a0387c14047dbdc965db8c0e5c06a281b81be8311e4b0c

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.