-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add documentation about e2ee #12821
Open
artonge
wants to merge
1
commit into
master
Choose a base branch
from
artonge/feat/add_deleting_metadata
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, some suggestions:
Thank you for this documentation! |
f8970e3
to
d5c9540
Compare
Signed-off-by: Louis Chemineau <[email protected]>
d5c9540
to
7a92483
Compare
@artonge If these are okay I can update the PR.
|
I would invert add and mnemonic, no? |
Ahh, yes that's right. I fixed the titles |
Ping @mgallien @marinofaggiana |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marinofaggiana @mgallien @alperozturk96 can you add screenshots for your respective platform?
Note: the android screenshots are in French, so they need to be replaced.
Fix nextcloud/end_to_end_encryption#936