Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow loading media as blob: #867

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Jan 16, 2025

And set the Content-Type header in proxied GET responses.

Related to nextcloud/viewer#2691

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.72%. Comparing base (f841a92) to head (b5d0cab).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/files.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
+ Coverage   37.56%   37.72%   +0.15%     
==========================================
  Files          33       33              
  Lines        1448     1450       +2     
  Branches       76       76              
==========================================
+ Hits          544      547       +3     
+ Misses        902      901       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artonge artonge force-pushed the artonge/feat/allow_loading_media_as_blob branch from ba92522 to b5d0cab Compare January 16, 2025 11:06
@artonge artonge requested a review from skjnldsv January 16, 2025 11:16
@artonge artonge self-assigned this Jan 16, 2025
@artonge artonge added 3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket php Pending a documentation update/fix labels Jan 16, 2025
@artonge artonge added this to the Nextcloud 31 milestone Jan 16, 2025
@artonge artonge merged commit 60e10e2 into master Jan 16, 2025
45 checks passed
@artonge artonge deleted the artonge/feat/allow_loading_media_as_blob branch January 16, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket php Pending a documentation update/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants