Skip to content

fix: wrap file_put_contents in a try/catch#435

Closed
st3iny wants to merge 2 commits intomasterfrom
fix/try-file-put-contents
Closed

fix: wrap file_put_contents in a try/catch#435
st3iny wants to merge 2 commits intomasterfrom
fix/try-file-put-contents

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Apr 24, 2025

Fix #434

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny marked this pull request as ready for review June 4, 2025 12:59
@st3iny st3iny requested a review from icewind1991 June 4, 2025 12:59
@icewind1991
Copy link
Member

I don't know if this is correct, failing to init the scanner should be blocking the write

@st3iny
Copy link
Member Author

st3iny commented Jun 16, 2025

I don't know if this is correct, failing to init the scanner should be blocking the write

Yeah, my thoughts exactly. We should not silently allow viruses just because the backend is not configured correctly.

@st3iny st3iny closed this Jun 16, 2025
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Jun 16, 2025
@st3iny st3iny deleted the fix/try-file-put-contents branch June 16, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

An error occurred when creating an Excel file.

2 participants