fix: Hide empty inline menu entry in grid view #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
fix/inline-grid-view
branch
from
4f768af to
4892d69
Compare
Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
force-pushed
the
fix/inline-grid-view
branch
from
4892d69 to
d84fe76
Compare
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
|
I'll add a test case as well |
|
@juliusknorr should we not just show some meaningful information? |
|
As mentioned in the other ticket we have another action for the menu entry: https://github.com/nextcloud/files_lock/blob/fix/inline-grid-view/src/main.ts#L113 |
susnux
approved these changes
Mar 13, 2025
This was referenced Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grid view currently does not support inline actions and renders them in the menu. This is a quick fix to address nextcloud/server#51452 to align with our other quick fix in https://github.com/nextcloud/files_lock/blob/main/src/main.ts#L98-L100