[stable29] Update php-cs-fixer to a PHP 8.3 compatible version #1105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous php-cs-fixer version was not compatible yet with PHP 8.3, so it may fail when run on CI if PHP 8.3, which is the latest supported version in Nextcloud 29, was used. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
bug
3. to review
dependencies
|
I guess this is no longer needed due to https://github.com/nextcloud/files_pdfviewer/pull/1111/files#diff-c6747bb752e9308e4440efab7e767917c2d7f0b35731b2e8ec23afc22521c1f4L31-R39 |
susnux
approved these changes
Jan 19, 2025
susnux
deleted the
stable29-update-php-cs-fixer-to-a-php8.3-compatible-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous php-cs-fixer version was not compatible yet with PHP 8.3, so it may fail when run on CI if PHP 8.3, which is the latest supported version in Nextcloud 29, was used.
See, for example, #1084