Update @nextcloud/eslint-config to 9.X #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumping the version with: npm install @nextcloud/[email protected] failed with: Conflicting peer dependency: [email protected] Due to that the version was bumped with: npm install --save-dev [email protected] npm install @nextcloud/[email protected] npm uninstall eslint Besides that the configuration file was migrated from the old ".eslintrc.js" to the new "eslint.config.mjs". Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
update-eslint-config-to-9
branch
from
bb41e1a to
787fe74
Compare
|
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
|
I think the reason is that you do not have eslint as a dev dependency |
susnux
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should ease the migration from Vue 2 to Vue 3 (although for now the Vue 2 rules are used in
eslint.config.mjs).Hacky bump
Bumping the version with:
failed with:
Due to that the version was bumped with:
I do not know if that is the right approach, if there are better approaches, or if could cause issues in the future 🤷