chore: unify debounce timing for input handling#2721
Merged
Conversation
Chartman123
added
javascript
Koc
reviewed
Apr 29, 2025
Chartman123
force-pushed
the
chore/unify-debounce-timeouts
branch
2 times, most recently
from
54b0af4 to
6ded74c
Compare
…nents Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123
force-pushed
the
chore/unify-debounce-timeouts
branch
from
6ded74c to
07c8468
Compare
susnux
reviewed
Apr 30, 2025
susnux
approved these changes
Apr 30, 2025
susnux
left a comment
susnux
left a comment
Collaborator
There was a problem hiding this comment.
works but dont agree with moving things out of context
Koc
approved these changes
Apr 30, 2025
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
Chartman123
force-pushed
the
chore/unify-debounce-timeouts
branch
from
07c8468 to
2e47154
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unifies the debounce timing for user inputs to 400 ms and also moves the definition to a new constant
INPUT_DEBOUNCE_MSin/src/models/Constants.ts