Skip to content

[stable5.2] fix(export): type numeric answers as numbers in exports#3369

Merged
Chartman123 merged 1 commit into
stable5.2from
fix/numeric-as-numbers-52
Jun 2, 2026
Merged

[stable5.2] fix(export): type numeric answers as numbers in exports#3369
Chartman123 merged 1 commit into
stable5.2from
fix/numeric-as-numbers-52

Conversation

@solracsf

Copy link
Copy Markdown
Member

Backport of #3368

@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Chartman123

Copy link
Copy Markdown
Collaborator

I'll close this one. Backports should be done automatically by the backportbot

@Chartman123 Chartman123 changed the title [5.2] fix(export): type numeric answers as numbers in exports [stable5.2] fix(export): type numeric answers as numbers in exports May 29, 2026
@Chartman123 Chartman123 reopened this May 29, 2026
@Chartman123

Copy link
Copy Markdown
Collaborator

Please add the tests here as well :)

@solracsf solracsf force-pushed the fix/numeric-as-numbers-52 branch from 499f3ee to cd326bf Compare May 29, 2026 13:10
@solracsf

Copy link
Copy Markdown
Member Author

Test had been added.

Why a different test shape than main: the 5.2 service has no setCellValue() method: the typing logic is inlined in exportData(). So instead of unit-testing a method directly, the test drives the private exportData() via invokePrivate, writes a real temp spreadsheet, reloads it with IOFactory::load(), and asserts the reloaded cell's getDataType().

It verifies the type survives a real write > read round-trip through the XLSX/ODS format.

@Chartman123

Copy link
Copy Markdown
Collaborator

@solracsf could you please resolve the merge conflicts? :)

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf force-pushed the fix/numeric-as-numbers-52 branch from 3ea9a12 to 2483617 Compare June 2, 2026 20:32
@solracsf

solracsf commented Jun 2, 2026

Copy link
Copy Markdown
Member Author

Done

@solracsf solracsf added the 3. to review Waiting for reviews label Jun 2, 2026
@solracsf solracsf requested a review from Chartman123 June 2, 2026 20:38
@Chartman123 Chartman123 merged commit 7804d10 into stable5.2 Jun 2, 2026
58 checks passed
@Chartman123 Chartman123 deleted the fix/numeric-as-numbers-52 branch June 2, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants