Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use owner instead of current user for move-to-trash logic #3543

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: use owner instead of current user for move-to-trash logic #3543

wants to merge 1 commit into from
+2 −1

Conversation

icewind1991
Copy link
Member

fixes #3496

@icewind1991 icewind1991 added the 3. to review Items that need to be reviewed label Jan 17, 2025
@icewind1991 icewind1991 added this to the Nextcloud 31 milestone Jan 17, 2025
@icewind1991 icewind1991 requested review from a team, nfebe, yemkareems and provokateurin and removed request for a team January 17, 2025 15:02
@icewind1991
Copy link
Member Author

/backport to stable30

@icewind1991
Copy link
Member Author

/backport to stable29

@icewind1991 icewind1991 mentioned this pull request Jan 17, 2025
Open
provokateurin
provokateurin approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a test would be nice

@provokateurin provokateurin mentioned this pull request Jan 17, 2025
Open
@kyteinsky
Copy link

maybe this fix could be extended to this line too for when anonymous users try to delete files. See #3544

@icewind1991
Copy link
Member Author

$user is supposed to be the account doing the deletion, not the owner

@kyteinsky
Copy link

yeah, the $user is used for the value of deleted_by and assumed to be a valid user id at some places so it doesn't seem to be trivial to fix. Better to address that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Items that need to be reviewed backport-request
Projects
None yet
Milestone
Nextcloud 31
3 participants
@icewind1991 @kyteinsky @provokateurin