refactor: Apply rector refactorings

lib/ACL/ACLCacheWrapper.php

@@ -17,8 +17,8 @@
 class ACLCacheWrapper extends CacheWrapper {
 	public function __construct(
 		ICache $cache,
-		private ACLManager $aclManager,
-		private bool $inShare,
+		private readonly ACLManager $aclManager,
+		private readonly bool $inShare,
 	) {
 		parent::__construct($cache);
 	}

lib/ACL/ACLManager.php

@@ -17,16 +17,16 @@
 use RuntimeException;
 
 class ACLManager {
-	private CappedMemoryCache $ruleCache;
+	private readonly CappedMemoryCache $ruleCache;
 
 	public function __construct(
-		private RuleManager $ruleManager,
-		private TrashManager $trashManager,
-		private LoggerInterface $logger,
-		private IUser $user,
-		private \Closure $rootFolderProvider,
+		private readonly RuleManager $ruleManager,
+		private readonly TrashManager $trashManager,
+		private readonly LoggerInterface $logger,
+		private readonly IUser $user,
+		private readonly \Closure $rootFolderProvider,
 		private ?int $rootStorageId = null,
-		private bool $inheritMergePerUser = false,
+		private readonly bool $inheritMergePerUser = false,
 	) {
 		$this->ruleCache = new CappedMemoryCache();
 	}

lib/ACL/ACLManagerFactory.php

@@ -15,11 +15,11 @@
 
 class ACLManagerFactory {
 	public function __construct(
-		private RuleManager $ruleManager,
-		private TrashManager $trashManager,
-		private IAppConfig $config,
-		private LoggerInterface $logger,
-		private \Closure $rootFolderProvider,
+		private readonly RuleManager $ruleManager,
+		private readonly TrashManager $trashManager,
+		private readonly IAppConfig $config,
+		private readonly LoggerInterface $logger,
+		private readonly \Closure $rootFolderProvider,
 	) {
 	}
 

lib/ACL/ACLStorageWrapper.php

@@ -17,8 +17,8 @@
 use OCP\Files\Storage\IStorage;
 
 class ACLStorageWrapper extends Wrapper implements IConstructableStorage {
-	private ACLManager $aclManager;
-	private bool $inShare;
+	private readonly ACLManager $aclManager;
+	private readonly bool $inShare;
 
 	public function __construct($arguments) {
 		parent::__construct($arguments);

lib/ACL/Rule.php

@@ -40,8 +40,8 @@ class Rule implements XmlSerializable, XmlDeserializable, \JsonSerializable {
 	 *                  and one that specifies the permissions to set for non inherited values (1-> allow, 0 -> deny)
 	 */
 	public function __construct(
-		private IUserMapping $userMapping,
-		private int $fileId,
+		private readonly IUserMapping $userMapping,
+		private readonly int $fileId,
 		private int $mask,
 		int $permissions,
 	) {
@@ -86,9 +86,6 @@ public function applyPermissions(int $permissions): int {
 	 * Apply the deny permissions this rule to an existing permission set, returning the resulting permissions
 	 *
 	 * Only the deny permissions included in the current mask will overwrite the existing permissions
-	 *
-	 * @param int $permissions
-	 * @return int
 	 */
 	public function applyDenyPermissions(int $permissions): int {
 		$invertedMask = ~$this->mask;
@@ -98,9 +95,6 @@ public function applyDenyPermissions(int $permissions): int {
 		return $permissions & $denyMask;
 	}
 
-	/**
-	 * @return void
-	 */
 	public function xmlSerialize(Writer $writer): void {
 		$data = [
 			self::ACL => [

lib/ACL/RuleManager.php

@@ -19,9 +19,9 @@
 
 class RuleManager {
 	public function __construct(
-		private IDBConnection $connection,
-		private IUserMappingManager $userMappingManager,
-		private IEventDispatcher $eventDispatcher,
+		private readonly IDBConnection $connection,
+		private readonly IUserMappingManager $userMappingManager,
+		private readonly IEventDispatcher $eventDispatcher,
 	) {
 	}
 

lib/ACL/UserMapping/UserMapping.php

@@ -9,14 +9,14 @@
 namespace OCA\GroupFolders\ACL\UserMapping;
 
 class UserMapping implements IUserMapping {
-	private string $displayName;
+	private readonly string $displayName;
 
 	/**
 	 * @param 'user'|'group'|'dummy' $type
 	 */
 	public function __construct(
-		private string $type,
-		private string $id,
+		private readonly string $type,
+		private readonly string $id,
 		?string $displayName = null,
 	) {
 		$this->displayName = $displayName ?? $id;

lib/ACL/UserMapping/UserMappingManager.php

@@ -15,8 +15,8 @@
 
 class UserMappingManager implements IUserMappingManager {
 	public function __construct(
-		private IGroupManager $groupManager,
-		private IUserManager $userManager,
+		private readonly IGroupManager $groupManager,
+		private readonly IUserManager $userManager,
 	) {
 	}
 

lib/AppInfo/Application.php

@@ -125,7 +125,6 @@ public function register(IRegistrationContext $context): void {
 				$c->get(FolderManager::class),
 				$c->get(TrashManager::class),
 				$c->get('GroupAppFolder'),
-				$c->get(MountProvider::class),
 				$c->get(ACLManagerFactory::class),
 				$c->get(IRootFolder::class),
 				$c->get(LoggerInterface::class),

lib/AppInfo/Capabilities.php

@@ -15,9 +15,9 @@
 
 class Capabilities implements ICapability {
 	public function __construct(
-		private IUserSession $userSession,
-		private FolderManager $folderManager,
-		private IAppManager $appManager,
+		private readonly IUserSession $userSession,
+		private readonly FolderManager $folderManager,
+		private readonly IAppManager $appManager,
 	) {
 	}
 

lib/AuthorizedAdminSettingMiddleware.php

@@ -21,8 +21,8 @@
 
 class AuthorizedAdminSettingMiddleware extends Middleware {
 	public function __construct(
-		private DelegationService $delegatedService,
-		private IRequest $request,
+		private readonly DelegationService $delegatedService,
+		private readonly IRequest $request,
 	) {
 	}
 

lib/BackgroundJob/ExpireGroupTrash.php

@@ -16,9 +16,9 @@
 
 class ExpireGroupTrash extends TimedJob {
 	public function __construct(
-		private TrashBackend $trashBackend,
-		private Expiration $expiration,
-		private IAppConfig $config,
+		private readonly TrashBackend $trashBackend,
+		private readonly Expiration $expiration,
+		private readonly IAppConfig $config,
 		ITimeFactory $timeFactory,
 	) {
 		parent::__construct($timeFactory);

lib/BackgroundJob/ExpireGroupVersions.php

@@ -19,10 +19,10 @@
 class ExpireGroupVersions extends TimedJob {
 	public function __construct(
 		ITimeFactory $time,
-		private GroupVersionsExpireManager $expireManager,
-		private IAppConfig $appConfig,
-		private FolderManager $folderManager,
-		private LoggerInterface $logger,
+		private readonly GroupVersionsExpireManager $expireManager,
+		private readonly IAppConfig $appConfig,
+		private readonly FolderManager $folderManager,
+		private readonly LoggerInterface $logger,
 	) {
 		parent::__construct($time);
 

lib/CacheListener.php

@@ -16,7 +16,7 @@
 
 class CacheListener {
 	public function __construct(
-		private IEventDispatcher $eventDispatcher,
+		private readonly IEventDispatcher $eventDispatcher,
 	) {
 	}
 

lib/Command/ACL.php

@@ -27,10 +27,10 @@ class ACL extends FolderCommand {
 	public function __construct(
 		FolderManager $folderManager,
 		IRootFolder $rootFolder,
-		private RuleManager $ruleManager,
+		private readonly RuleManager $ruleManager,
 		MountProvider $mountProvider,
-		private ACLManagerFactory $aclManagerFactory,
-		private IUserManager $userManager,
+		private readonly ACLManagerFactory $aclManagerFactory,
+		private readonly IUserManager $userManager,
 	) {
 		parent::__construct($folderManager, $rootFolder, $mountProvider);
 	}
@@ -117,8 +117,16 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 			$mappingType = $input->getOption('user') ? 'user' : 'group';
 			$mappingId = $input->getOption('user') ?: $input->getOption('group');
 			$path = $input->getArgument('path');
+			if (!is_string($path)) {
+				$output->writeln('<error><path> argument has to be a string</error>');
+				return -3;
+			}
 			$path = trim($path, '/');
 			$permissionStrings = $input->getArgument('permissions');
+			if (!is_array($permissionStrings)) {
+				$output->writeln('<error><permissions> argument has to be an array</error>');
+				return -3;
+			}
 
 			$mount = $this->mountProvider->getMount(
 				$folder['id'],
@@ -147,6 +155,11 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 			}
 
 			foreach ($permissionStrings as $permission) {
+				if (!is_string($permission)) {
+					$output->writeln('<error><permissions> argument has to be an array of strings</error>');
+					return -3;
+				}
+
 				if ($permission[0] !== '+' && $permission[0] !== '-') {
 					$output->writeln('<error>incorrect format for permissions "' . $permission . '"</error>');
 					return -3;
@@ -216,6 +229,9 @@ private function printPermissions(InputInterface $input, OutputInterface $output
 		}
 	}
 
+	/**
+	 * @param list<string> $permissions
+	 */
 	private function parsePermissions(array $permissions): array {
 		$mask = 0;
 		$result = 0;

lib/Command/Create.php

@@ -16,7 +16,7 @@
 
 class Create extends Base {
 	public function __construct(
-		private FolderManager $folderManager,
+		private readonly FolderManager $folderManager,
 	) {
 		parent::__construct();
 	}

lib/Command/ExpireGroup/ExpireGroupTrash.php

@@ -15,8 +15,8 @@
 
 class ExpireGroupTrash extends ExpireGroupBase {
 	public function __construct(
-		private TrashBackend $trashBackend,
-		private Expiration $expiration,
+		private readonly TrashBackend $trashBackend,
+		private readonly Expiration $expiration,
 	) {
 		parent::__construct();
 	}

lib/Command/ExpireGroup/ExpireGroupVersions.php

@@ -21,8 +21,8 @@
  */
 class ExpireGroupVersions extends ExpireGroupBase {
 	public function __construct(
-		private GroupVersionsExpireManager $expireManager,
-		private IEventDispatcher $eventDispatcher,
+		private readonly GroupVersionsExpireManager $expireManager,
+		private readonly IEventDispatcher $eventDispatcher,
 	) {
 		parent::__construct();
 	}

lib/Command/ExpireGroup/ExpireGroupVersionsTrash.php

@@ -19,8 +19,8 @@ class ExpireGroupVersionsTrash extends ExpireGroupVersions {
 	public function __construct(
 		GroupVersionsExpireManager $expireManager,
 		IEventDispatcher $eventDispatcher,
-		private TrashBackend $trashBackend,
-		private Expiration $expiration,
+		private readonly TrashBackend $trashBackend,
+		private readonly Expiration $expiration,
 	) {
 		parent::__construct($expireManager, $eventDispatcher);
 	}

lib/Command/Group.php

@@ -29,7 +29,7 @@ class Group extends FolderCommand {
 	public function __construct(
 		FolderManager $folderManager,
 		IRootFolder $rootFolder,
-		private IGroupManager $groupManager,
+		private readonly IGroupManager $groupManager,
 		MountProvider $mountProvider,
 	) {
 		parent::__construct($folderManager, $rootFolder, $mountProvider);

lib/Command/ListCommand.php

@@ -30,10 +30,10 @@ class ListCommand extends Base {
 
 
 	public function __construct(
-		private FolderManager $folderManager,
-		private IRootFolder $rootFolder,
-		private IGroupManager $groupManager,
-		private IUserManager $userManager,
+		private readonly FolderManager $folderManager,
+		private readonly IRootFolder $rootFolder,
+		private readonly IGroupManager $groupManager,
+		private readonly IUserManager $userManager,
 	) {
 		parent::__construct();
 	}

lib/Command/Quota.php

@@ -29,7 +29,13 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 			return -1;
 		}
 
-		$quotaString = strtolower($input->getArgument('quota'));
+		$quotaString = $input->getArgument('quota');
+		if (!is_string($quotaString)) {
+			$output->writeln('<error><quota> argument has to be a string</error>');
+			return -3;
+		}
+
+		$quotaString = strtolower($quotaString);
 		$quota = ($quotaString === 'unlimited') ? FileInfo::SPACE_UNLIMITED : \OCP\Util::computerFileSize($quotaString);
 		if ($quota) {
 			$this->folderManager->setFolderQuota($folder['id'], (int)$quota);

lib/Command/Scan.php

@@ -71,7 +71,12 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 		}
 
 		$inputPath = $input->getOption('path');
-		if ($inputPath) {
+		if ($inputPath !== null) {
+			if (!is_string($inputPath)) {
+				$output->writeln('<error><path> option has to be a string</error>');
+				return -3;
+			}
+
 			$inputPath = '/' . trim($inputPath, '/');
 		} else {
 			$inputPath = '';

lib/Command/Trashbin/Cleanup.php

@@ -24,7 +24,7 @@ class Cleanup extends Base {
 	private ?TrashBackend $trashBackend = null;
 
 	public function __construct(
-		private FolderManager $folderManager,
+		private readonly FolderManager $folderManager,
 	) {
 		parent::__construct();
 		if (Server::get(IAppManager::class)->isEnabledForUser('files_trashbin')) {

lib/Controller/FolderController.php

@@ -35,18 +35,18 @@
  * @psalm-import-type InternalFolderOut from FolderManager
  */
 class FolderController extends OCSController {
-	private ?IUser $user;
+	private readonly ?IUser $user;
 
 	public function __construct(
 		string $AppName,
 		IRequest $request,
-		private FolderManager $manager,
-		private MountProvider $mountProvider,
-		private IRootFolder $rootFolder,
+		private readonly FolderManager $manager,
+		private readonly MountProvider $mountProvider,
+		private readonly IRootFolder $rootFolder,
 		IUserSession $userSession,
-		private FoldersFilter $foldersFilter,
-		private DelegationService $delegationService,
-		private IGroupManager $groupManager,
+		private readonly FoldersFilter $foldersFilter,
+		private readonly DelegationService $delegationService,
+		private readonly IGroupManager $groupManager,
 	) {
 		parent::__construct($AppName, $request);
 		$this->user = $userSession->getUser();