OCS API Returns updated groupfolder data after modifications #3666
Conversation
There was a problem hiding this comment.
Please see #3665 (comment), we can't break the format in a way that is not backwards compatible.
Other than that this is a really good idea and the PR looks fine!
|
Sorry, I submitted my PR before I saw your comment. I'll give it a go and update my PR with the changes. |
|
No problem! I guess you already had the changes ready when you created the issue. You don't need to open an issue before creating a PR to fix it. It's only really necessary if there is a need to discuss a problem or if you are not going to fix it yourself right away. |
|
Btw to generate the OpenAPI spec just run |
aaronsegura
force-pushed
the
return-new-object-after-changes
branch
2 times, most recently
from
dc92b47 to
53c34b9
Compare
aaronsegura
force-pushed
the
return-new-object-after-changes
branch
from
53c34b9 to
66ae8bc
Compare
aaronsegura
force-pushed
the
return-new-object-after-changes
branch
from
66ae8bc to
e100eb4
Compare
provokateurin
force-pushed
the
return-new-object-after-changes
branch
from
e100eb4 to
e3a3510
Compare
|
Hey @aaronsegura I took over the PR because I realized that some more changes are missing and we were going a bit back and forth here. I hope that was OK. The PR is fine now and I will merge it once the CI is done and green. |
Resolves #3665 Signed-off-by: Aaron Segura <[email protected]> Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
return-new-object-after-changes
branch
from
e3a3510 to
6920007
Compare
|
No idea why psalm fails on pcntl, but locally it's green: So merging it, even though it's red 🤷♀️ |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Resolves #3665