Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh: Use Delete icon instead of Close icon #3705

Merged
merged 1 commit into from
Mar 19, 2025
Merged

enh: Use Delete icon instead of Close icon #3705

merged 1 commit into from
Mar 19, 2025
+4 −5

Conversation

solracsf
Copy link
Member

Fix #3704

@solracsf solracsf added 3. to review Items that need to be reviewed design Items related to the web UI (layout, design, etc.) labels Mar 19, 2025
@provokateurin
Copy link
Member

Please fix eslint. Psalm is currently broken, but also irrelevant for a frontend-only change.

@solracsf
Copy link
Member Author

Fixed. I'll also backport this to 31/30 if no objections?

@provokateurin
Copy link
Member

Sure

@provokateurin provokateurin merged commit 4fb34e2 into master Mar 19, 2025
50 of 51 checks passed
@provokateurin provokateurin deleted the useDeleteIcon branch March 19, 2025 09:58
@solracsf
Copy link
Member Author

/backport to stable31

@solracsf
Copy link
Member Author

/backport to stable30

This was referenced Mar 19, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

Assignees
No one assigned
Labels
3. to review Items that need to be reviewed design Items related to the web UI (layout, design, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace delete icon on ACL page
2 participants
@solracsf @provokateurin