fix: perform bulk message actions #10280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianKrupinski
force-pushed
the
fix/bulk-actions
branch
from
313785b to
f92842a
Compare
SebastianKrupinski
force-pushed
the
fix/bulk-actions
branch
5 times, most recently
from
5ab79af to
7d4f62f
Compare
| foreach ($accounts as $account) { | ||
| $account = new Account($account); | ||
| // determine if account belongs to the user and skip if not | ||
| if ($account->getUserId() != $userId) { |
There was a problem hiding this comment.
Good to check, but please move this down into the db when looking up accounts. Make it a WHERE id IN (xxx) AND user_id = 'sebastian'. That avoids loaded any foreign accounts.
|
Pslam complaints: will be dealt with, once the reviewed |
|
Merge: broke front end, reverting to draft |
Signed-off-by: SebastianKrupinski <[email protected]>
SebastianKrupinski
force-pushed
the
fix/bulk-actions
branch
from
ae9a9a8 to
6e1bc18
Compare
Signed-off-by: SebastianKrupinski <[email protected]>
Signed-off-by: SebastianKrupinski <[email protected]>
|
@SebastianKrupinski the PR state says ready for review and the label say 2. developing. What is the status here? |
Yes, its ready to review. It was late at night after along day, when I uploaded this an forgot to change the labels |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bulk mail message operations