fix: Adjust TaskProcessingListener #10620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianKrupinski
requested review from
ChristophWurst,
kesselb and
GretaD
as code owners
SebastianKrupinski
requested review from
hamza221
and removed request for
ChristophWurst,
kesselb and
GretaD
Signed-off-by: SebastianKrupinski <[email protected]>
SebastianKrupinski
force-pushed
the
fix/10616-adjust-taskprocessinglistener
branch
from
3064c35 to
4ee353b
Compare
SebastianKrupinski
deleted the
fix/10616-adjust-taskprocessinglistener
branch
hamza221
reviewed
Jan 29, 2025
| @@ -104,7 +101,7 @@ public function summarizeMessages(Account $account, array $messages): void { | |||
| "Here is the ***E-MAIL*** for which you must generate a helpful summary: \r\n" . | |||
| "***START_OF_E-MAIL***\r\n$messageBody\r\n***END_OF_E-MAIL***\r\n"; | |||
| $task = new TaskProcessingTask( | |||
| TextToText::ID, | |||
| TextToTextSummary::ID, | |||
There was a problem hiding this comment.
It should be TextToTextas TextToTextSummary already has a prompt built in see #10611
There was a problem hiding this comment.
Dang it, you changed it, I didn't notice this
There was a problem hiding this comment.
Okay, Ill submit another PR to change this back
There was a problem hiding this comment.
You didn't adjust the function that actually listens to the completed summary, so when I looked at the code i thought I made a mistake.
There was a problem hiding this comment.
yeah I just realised, my bad sorry
|
/backport to stable4.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #10616