-
Notifications
You must be signed in to change notification settings - Fork 270
Fix text cutting off when printing and differences between clicking print and doing ctrl + P #10670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note: narrow messages in firefox seem to reproducible only after having clicked the menu buttons in the thread element, even though the menu was subsequently closed..? |
0d018da
to
4981e8f
Compare
This feels a bit bumpy, but I also lack alternative ideas off the top of my head … |
I tried reinserting the deleted elements back afterwards, but I can't figure out how to insert them back into the right place, they kept getting appended to the end of the component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Single mails and threads, works good.
f1acc9f
to
ac0318a
Compare
Signed-off-by: Grigory Vodyanov <[email protected]>
ac0318a
to
e373f05
Compare
/backport to stable4.3 |
The backport to # Switch to the target branch and update it
git checkout stable4.3
git pull origin stable4.3
# Create the new backport branch
git checkout -b backport/10670/stable4.3
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e373f05a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/10670/stable4.3 Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Fix #9853
Previously for printing all we did was hide unnecessary DOM elements with CSS
What this PR actually does:
Ctrl + P
Ctrl + P
some DOM elements are hidden with CSS, and some are removed forcefully with javascript. This is needed because browser printing APIs aren't the best, and even hidden elements mess up the layout with Chrome. The downside of this is that the browser cannot read elements inside of iframes, so text and images are split between multiple pages. After this is done the page has to be reloaded to restore the deleted elements.