fix(composer): handling of plain and html bodies #10754
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
|
Question, since you are reworking this, now that we have the htmlBody and plainBody, can we get ride of the editorBody? |
Yes, we should be able to get rid. However, I'd move this to another PR. |
|
/backport to stable4.3 |
|
/backport to stable5.0 |
|
One thing to note: I didn't check if automated message are not editable. Sebastian told me that they can only be detected by their missing |
|
Tested. All function in description seem to work correctly |
SebastianKrupinski
approved these changes
Apr 5, 2025
|
4.2 backport stopped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10747
Things I tested