fix: harden phishing detection against missing and malformed headers #10760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
requested review from
ChristophWurst,
kesselb and
GretaD
as code owners
|
/backport to stable4.2 |
st3iny
commented
Feb 27, 2025
Comment on lines
-30
to
+29
| } catch (DateException $e) { | ||
| } catch (\Exception $e) { |
There was a problem hiding this comment.
Not ideal, but on my instance the time factory throws a generic Exception.
{
"type": "Exception",
"message": "Failed to parse time string (Wed, 26 Feb 2025 12:09:28 +0100 (GMT+01:00)) at position 36 (+): Double timezone specification",
}
kesselb
approved these changes
Feb 27, 2025
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
fix/phishing-detection-hardening
branch
from
8c6b678 to
f8338e6
Compare
st3iny
changed the title
|
Done, I added some unit tests and more test data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10753
Fix #10361
Ref #10602
Closes #10371 (alternative to)
Before: Emails with missing headers can't be opened, for example, the date header.
After: Emails can be opened again.
(See the referenced tickets for some example EML files to test this with).