Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: html5 tag errors #10763

Merged
merged 1 commit into from
Feb 27, 2025
Merged

fix: html5 tag errors #10763

merged 1 commit into from
Feb 27, 2025

Conversation

SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented Feb 27, 2025

Resolves: Client Issue

Summery

  • Adds DOCTYPE to html wrapper to prevent libxml errors for html 5 tag "DOMDocument::loadHTML(): Tag figure invalid in Entity, line: 1"
  • Adds limitation to prevent network access for DOMDocument

Signed-off-by: SebastianKrupinski <[email protected]>
@SebastianKrupinski SebastianKrupinski self-assigned this Feb 27, 2025
@SebastianKrupinski SebastianKrupinski changed the title fix: html5 errors fix: html5 tag errors Feb 27, 2025
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Is only main affected by this or should it be backported to stable releases?

@SebastianKrupinski
Copy link
Contributor Author

Looks good

Is only main affected by this or should it be backported to stable releases?

Yes I would back port it to all the versions that support NC30+

@SebastianKrupinski
Copy link
Contributor Author

Looks good

Is only main affected by this or should it be backported to stable releases?

Wait that might not be possible, I made changes to that code block recently, I'll check how far back it went

@SebastianKrupinski
Copy link
Contributor Author

SebastianKrupinski commented Feb 27, 2025

Yes, we would need to backport this also...

#10477

@st3iny
Copy link
Member

st3iny commented Feb 27, 2025

Not necessarily. The fix also makes sense on top of the state before your alternate format fix. Although, a manual backport will be necessary.

Ref https://github.com/nextcloud/mail/blob/3f821e38e37cda3c1ae165a141f1b38f62191fbe/lib/Service/MimeMessage.php

@st3iny st3iny added this to the v4.3.0 milestone Feb 27, 2025
@st3iny
Copy link
Member

st3iny commented Feb 27, 2025

/backport to stable4.2

@st3iny st3iny merged commit b507ee3 into main Feb 27, 2025
35 checks passed
@st3iny st3iny deleted the fix/noid/html5-and-network-access branch February 27, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants