Skip to content

update eslint #11892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

update eslint #11892

wants to merge 11 commits into from

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 8, 2025 •
edited
Loading

I'd recommend reviewing it commit by commit.

The commit style: apply @nextcloud/eslint-config 9 (74a7a42) is the result of running npm run lint:fix.

All other commits contain manual adjustments.

Some of the rules from #11784 are currently disabled, they were conflicting with rules introduced by our eslint 9 configuration.

Noteable changes:

  • close-on-select was replaced by keep-open (the default is to close on select)
  • NcSelect with user-select="true" to NcSelectUsers

@kesselb kesselb force-pushed the update-eslint2 branch 6 times, most recently from a377660 to b6495c0 Compare October 9, 2025 09:59
@kesselb kesselb self-assigned this Oct 9, 2025
kesselb added 11 commits October 9, 2025 12:25
@kesselb
chore(eslint): upgrade eslint
9b80c71 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb
style: apply @nextcloud/eslint-config 9
fd6efcf 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb
fix: drop deprecated close-on-select
f9933eb 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb
fix: use no-focus-trap instead of the deprecated focus-trap
55ddbc9 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb
style: The relative import should probably have the file extension
edeba06 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb
style: InvalidPkcs12CertificateError was used before it was defined
f200251 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb
style: unnecessary escape character
7944f75 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb
chore: suppress no-undef warnings
5a08e66 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb
fix: replace NcSelect with NcSelectUsers
a57bf8c 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb
fix: remove unused isMobile mixin
2d671eb 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb
fix: import isMobile from nextcloud/vue
9c77aad 
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb marked this pull request as ready for review October 9, 2025 10:28
@kesselb kesselb mentioned this pull request Oct 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@kesselb kesselb

Labels

3. to review bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kesselb