fix(ui): improve color contrast of tags#12058
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
|
@nimishavijay could you please give early feedback? Is the approach acceptable design-wise? |
|
Nice improvements on the visual design aspects like rounding corners etc. I agree that the color contrast can be improved, but going with such bright colours seems like possibly a regression design-wise. We could use very dark and very light versions of the tag color, similar to before, and additionally add a 1px border. Something like this: since --main-text and --main-bg always have very high contrast, it should work. What do you think? |
|
The rounding is a side effect of deduplicating four copies of the more or less same code for tags 🌝 The tags will look like this with the suggested CSS: 
This works in terms of text readability but we'll lose most of the color |
| }, | ||
| }) | ||
|
|
||
| // Source - https://stackoverflow.com/a |
There was a problem hiding this comment.
| // Source - https://stackoverflow.com/a | |
| // Source - https://stackoverflow.com/a/9733420 |
|
You're right, but design wise this seems to be in the right direction (ref outlook as well) How about |
3 participants
Fixes #5149