Skip to content

Conversation

@SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented Dec 8, 2025

Summary

Testing

  • Navigate to mail account settings, turn on "Automatically create tentative appointments"
  • Using another external account/service send a calendar invitation to the configure nc mail account
  • Trigger cron job to run background jobs
image

@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 9, 2025

What about #11756?

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

Is the server change a hard requirement? If so, add a version check

@SebastianKrupinski
Copy link
Contributor Author

Is the server change a hard requirement? If so, add a version check

This only is a issue in version 31 kind of, the required method is protected, we can discuss in 1 to 1

@SebastianKrupinski SebastianKrupinski force-pushed the feat/tentative-invitations branch from 4a22577 to fc8df6a Compare January 5, 2026 17:50
Copy link
Contributor

@DerDreschner DerDreschner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on my machine, but does work only on messages delivered to the Inbox. When creating a rule on Webmin/Virtualmin to put it in another folder, it doesn't work anymore. But I guess that's expected behaviour. 😃 Their implementation doesn't use Sieve, so, it may differ there.

Looking forward to use it on a daily basis!

@SebastianKrupinski
Copy link
Contributor Author

Tested successfully on my machine, but does work only on messages delivered to the Inbox. When creating a rule on Webmin/Virtualmin to put it in another folder, it doesn't work anymore. But I guess that's expected behaviour. 😃 Their implementation doesn't use Sieve, so, it may differ there.

This should work on other mail boxes, we process all the mail boxes, the issue might be that the alternate mailbox has not been sync'd with NC yet, we do not sync all mailboxes all the time.

@DerDreschner
Copy link
Contributor

Yep, that was indeed the issue here! When marking the mailbox as Sync in background, it works. Opening the folder with Subscribed enabled alone is not enough though.

$schedulingInfo['contents'],
[
'recipient' => $recipient,
'absent' => $imipCreate ? 'create' : 'ignore',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server PR is merged... will rebase in a couple hours will see what psalm says

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static-psalm-analysis dev-master should pass 🥳

static-psalm-analysis dev-stable32 will still fail 💥

We could change OCP\Calendar\IManager.handleIMip in stable32 like

@param array{absent?: "create"|"ignore", recipient?: string, ...} $options

To avoid the warning about "ignore" and make psalm more relax about the unknown "absentCreateStatus" with the "...".

That isn't ideal, but at least we don't have to suppress some errors or bump the baseline only for one supported version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... I agree we need to adjust stable32 cause psalm will wine again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: SebastianKrupinski <[email protected]>
@SebastianKrupinski SebastianKrupinski force-pushed the feat/tentative-invitations branch from db9c9cd to ba04fde Compare January 15, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🏗️ In progress

Development

Successfully merging this pull request may close these issues.

Add invites to calendar automatically (tentative without respond)

5 participants