-
Notifications
You must be signed in to change notification settings - Fork 295
feat: automated appointment creation #12144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
What about #11756? |
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far
Is the server change a hard requirement? If so, add a version check
This only is a issue in version 31 kind of, the required method is protected, we can discuss in 1 to 1 |
4a22577 to
fc8df6a
Compare
5f98012 to
298907f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully on my machine, but does work only on messages delivered to the Inbox. When creating a rule on Webmin/Virtualmin to put it in another folder, it doesn't work anymore. But I guess that's expected behaviour. 😃 Their implementation doesn't use Sieve, so, it may differ there.
Looking forward to use it on a daily basis!
This should work on other mail boxes, we process all the mail boxes, the issue might be that the alternate mailbox has not been sync'd with NC yet, we do not sync all mailboxes all the time. |
|
Yep, that was indeed the issue here! When marking the mailbox as |
| $schedulingInfo['contents'], | ||
| [ | ||
| 'recipient' => $recipient, | ||
| 'absent' => $imipCreate ? 'create' : 'ignore', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Server PR is merged... will rebase in a couple hours will see what psalm says
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static-psalm-analysis dev-master should pass 🥳
static-psalm-analysis dev-stable32 will still fail 💥
We could change OCP\Calendar\IManager.handleIMip in stable32 like
@param array{absent?: "create"|"ignore", recipient?: string, ...} $options
To avoid the warning about "ignore" and make psalm more relax about the unknown "absentCreateStatus" with the "...".
That isn't ideal, but at least we don't have to suppress some errors or bump the baseline only for one supported version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... I agree we need to adjust stable32 cause psalm will wine again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f5d338d to
db9c9cd
Compare
Signed-off-by: SebastianKrupinski <[email protected]>
db9c9cd to
ba04fde
Compare
Summary
Testing