fix(OutOfOfficeForm): datepicker overlapping with sidebar#12303
Open
fix(OutOfOfficeForm): datepicker overlapping with sidebar#12303
Conversation
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
ChristophWurst
approved these changes
Jan 23, 2026
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
LGTM
This is being caused by the main view of the settings having its overflow hidden by the sidebar
Out of curiosity, would lifting this in the upstream component be a problem? I assume any other floating elements inside settings are currently prone to a cut-off.
|
|
||
| #ooo-first-day { | ||
| :deep(.mx-datepicker-popup) { | ||
| left: 0 !important; |
Member
There was a problem hiding this comment.
stylelint wants inset-inline-start. guess that make sense if the input is on the right in RTL mode
Contributor
|
You can run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is being caused by the main view of the settings having its overflow hidden by the sidebar, and the popup of the datepicker is contained inside the main view and isn't appended somewhere later in the DOM
The ideal solution here would be to have the popup somewhere else where it isn't constrained, but seeing as it comes from a third party library I don't know what we can do about that.