[stable5.6] fix(composer): drop envelope from store when saving a draft#12332
Open
backportbot[bot] wants to merge 1 commit intostable5.6from
Open
[stable5.6] fix(composer): drop envelope from store when saving a draft#12332backportbot[bot] wants to merge 1 commit intostable5.6from
backportbot[bot] wants to merge 1 commit intostable5.6from
Conversation
backportbot
bot
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
Addresses a timing issue when updating drafts. Since drafts are immutable, updating a draft deletes the old message and creates a new one. If the user is quick or the sync is slow, the draft being deleted can still appear in the list after closing the composer. Reopening that envelope/draft leads to a state where further edits fail. This change removes the envelope from the store to avoid this problem. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #12322