Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump @nextcloud/files from 2.1.0 to v3 (main) #8144

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 24, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@nextcloud/files ^2.1.0 -> ^3.1.0 age adoption passing confidence

Release Notes

nextcloud-libraries/nextcloud-files (@​nextcloud/files)

v3.1.0

Compare Source

Enhancements
Fixed

v3.0.0

Compare Source

Breaking
Enhancements
Fixed

Full Changelog: nextcloud-libraries/nextcloud-files@v2.1.0...v3.0.0


Configuration

📅 Schedule: Branch creation - "before 5am on wednesday" in timezone Europe/Vienna, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@ChristophWurst
Copy link
Member

I'm unable to find the breaking change

@renovate renovate bot force-pushed the renovate/main-nextcloud-files-3.x branch from bee8135 to eff2de7 Compare February 27, 2023 08:36
@renovate renovate bot force-pushed the renovate/main-nextcloud-files-3.x branch from eff2de7 to e48180b Compare March 23, 2023 12:33
@renovate renovate bot force-pushed the renovate/main-nextcloud-files-3.x branch from e48180b to 75be66f Compare April 7, 2023 07:49
@renovate renovate bot force-pushed the renovate/main-nextcloud-files-3.x branch 2 times, most recently from 4138a7f to 7cd6681 Compare April 24, 2023 11:29
@renovate renovate bot force-pushed the renovate/main-nextcloud-files-3.x branch from 7cd6681 to be52e14 Compare June 14, 2023 10:35
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't build

@renovate renovate bot force-pushed the renovate/main-nextcloud-files-3.x branch from be52e14 to 8911994 Compare July 4, 2023 12:52
@renovate renovate bot force-pushed the renovate/main-nextcloud-files-3.x branch 3 times, most recently from a827137 to 4642e07 Compare August 3, 2023 12:35
@renovate renovate bot force-pushed the renovate/main-nextcloud-files-3.x branch 2 times, most recently from 9369ca7 to 8bf9f21 Compare August 9, 2023 11:45
@renovate renovate bot force-pushed the renovate/main-nextcloud-files-3.x branch 5 times, most recently from ced4eaf to 9ab5ffd Compare August 24, 2023 07:10
@renovate renovate bot force-pushed the renovate/main-nextcloud-files-3.x branch 3 times, most recently from a55a7d4 to 110c373 Compare September 5, 2023 10:33
@renovate renovate bot force-pushed the renovate/main-nextcloud-files-3.x branch 3 times, most recently from f49042c to fb6cea9 Compare September 25, 2023 16:21
@GretaD
Copy link
Contributor

GretaD commented Sep 29, 2023

ERROR in ./node_modules/@nextcloud/files/node_modules/webdav/dist/node/request.js 2:0-44
Module not found: Error: Can't resolve 'https' in '/var/www/nextcloud/server/apps/mail/node_modules/@nextcloud/files/node_modules/webdav/dist/node'
Did you miss the leading dot in 'resolve.extensions'? Did you mean '[".*",".js",".vue",".json"]' instead of '["*",".js",".vue",".json"]'?


@ChristophWurst
Copy link
Member

Failure related to perry-mitchell/webdav-client#356. Let's update the webdav lib on main first, then retry this bump.

@renovate renovate bot force-pushed the renovate/main-nextcloud-files-3.x branch from fb6cea9 to 8781e52 Compare October 3, 2023 20:01
@renovate renovate bot force-pushed the renovate/main-nextcloud-files-3.x branch from 8781e52 to 07fcfc5 Compare October 11, 2023 07:21
@skjnldsv
Copy link
Member

I think your webpack config is the issue

@renovate renovate bot force-pushed the renovate/main-nextcloud-files-3.x branch 2 times, most recently from fef9058 to ce31682 Compare November 8, 2023 13:34
@ChristophWurst ChristophWurst mentioned this pull request Nov 29, 2023
24 tasks
@renovate renovate bot force-pushed the renovate/main-nextcloud-files-3.x branch from ce31682 to a944f0e Compare January 9, 2024 15:50
@st3iny
Copy link
Member

st3iny commented Feb 21, 2024

Hmm, this builds fine locally. Let's try to rebase ...

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/main-nextcloud-files-3.x branch from a944f0e to 2de7e60 Compare February 21, 2024 10:20
@ChristophWurst
Copy link
Member

@nextcloud/files depends on path, which is not available in browsers. The lib works in other apps only because @nextcloud/webpack-vue-config pulls in node-polyfill-webpack-plugin with path-browserify.

Copy link
Contributor Author

renovate bot commented Feb 22, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Christoph's analysis showed that we had to adjust our polyfills.

I tested the js dashboard widgets on stable26 to make sure there were no regressions. Some of the polyfills were added to prevent it from loading forever.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 🚀

@ChristophWurst ChristophWurst merged commit cf6d971 into main Feb 22, 2024
36 checks passed
@ChristophWurst ChristophWurst deleted the renovate/main-nextcloud-files-3.x branch February 22, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants