Skip to content

Fix/589/import issues#598

Merged
newhinton merged 2 commits intonextcloud:masterfrom
Oliv4945:fix/589/ImportIssues
Jun 14, 2019
Merged

Fix/589/import issues#598
newhinton merged 2 commits intonextcloud:masterfrom
Oliv4945:fix/589/ImportIssues

Conversation

@Oliv4945
Copy link
Collaborator

@Oliv4945 Oliv4945 commented Jun 4, 2019

The compromised field of credentials object was not created by the importer, so there was an exception when encrypting the fields as undefined was pasted to the encryption library.

Should fix #589

closes #589

@Oliv4945 Oliv4945 force-pushed the fix/589/ImportIssues branch from a674361 to 9401cb8 Compare June 4, 2019 13:35
@Oliv4945 Oliv4945 force-pushed the fix/589/ImportIssues branch from 9401cb8 to e222610 Compare June 4, 2019 13:40
Signed-off-by: Oliv4945 <oliv4945@gmail.com>
Signed-off-by: Oliv4945 <oliv4945@gmail.com>
@Oliv4945 Oliv4945 force-pushed the fix/589/ImportIssues branch from 0aa7e91 to 4b1c9ba Compare June 14, 2019 13:59
@newhinton newhinton merged commit a40929d into nextcloud:master Jun 14, 2019
@robin-thoni
Copy link

@Oliv4945 Thanks for the fix!

@newhinton That's a critical issue for people trying to migrate to passman. When can we expect this fix to be available? Thanks!

@newhinton
Copy link
Collaborator

it is merged, and will be shipped with the next release. However, there is no specific date when it will be released. But i guess it wont take long, maybe next week or so

@robin-thoni
Copy link

Sounds fair. Thanks again!

@newhinton
Copy link
Collaborator

You're welcome ;)

@robin-thoni
Copy link

Any news on updating the chrome app...?

"Updated
September 10, 2018"

That sounds a little bit old, although I totally understand it might not be your full time job. However, I think a few of us could be interested in collaborating and increasing the release cycle :) Currently the project sounds dead, which is a shame, as it is for me a really promising password manager.

@newhinton
Copy link
Collaborator

This project is not dead, we releases 2.3.2 just monday

are there issues with the current passman extension that require an update? while there are features that are not released for the extension, it is quiet stable afaik

@robin-thoni
Copy link

robin-thoni commented Jul 12, 2019

This project is not dead

Ah! That's cool to hear that :)

are there issues with the current passman extension that require an update?

Not that I'm aware of.

while there are features that are not released for the extension, it is quiet stable afaik

I just realized this thread was about backend... Yeah, I meant updating the Nextcloud app, sorry... Friday evening... That's not the subject here, but as you're asking, the workflow to add a vault is "terrible" for two points:

  • Leaving the focus will cancel adding a vault. That's more a Chrome (Firefox too? Didn't tested) problem, but that could be mitigated by allowing to use the same (without actually erasing all settings and resetting master password) page as the first setup. Use case is I use random passwords for vaults and an app password for login (because of U2F). That means I currently have to write at least of the passwords by hand, cause it is not possible to leave the focus to copy the second one.
  • We have to login x times to add x vaults from the same account. Having a concept of accounts and vaults related to those would seriously simplify that workflow. Also, I store my other vaults passwords in my main one. Having a built-in feature to automatically use them would be even more awesome (for example, convention could be "passman-vault-${vault-name-or-id}".

Passwords are critical, and I have troubles to implement a user friendly workflow for my users, which is why I'd like to see those features. As it is critical to me, I'm ready to implement (some of) those features, and helping as much as I can, if we can have regular releases (when there's new features, of course).

@newhinton
Copy link
Collaborator

if you want to, you can always check out github.com/nextcloud/passman-webextension

(also, please file issues/features there, they will be overlooked here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Import from LastPass or KeePass impossible

4 participants