-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(settings): add admin & user setting iframe #4373
Open
codewithvk
wants to merge
28
commits into
nextcloud:main
Choose a base branch
from
codewithvk:private/codewithvk/cool_setting_iframe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
53534ce
Initial cool admin setting iframe setup
codewithvk f633c8b
WIP auth
codewithvk bf89c30
Temp: Auth handling stuff
codewithvk f2bb53f
WIP: wopi setting upload
codewithvk 0b8223d
Created an AppData-based directory for system settings and user settings
codewithvk 21057fe
Create a Settings controller API endpoint for handling AppData-based …
codewithvk d713272
Temporary Commit: Created a temporary UI to validate the functionalit…
codewithvk 93ac420
Change the admin settings iframe URL to adminIntegratorSettings.
codewithvk 75c4810
WOPI: Update the wopi setting upload route to accept a file and store…
codewithvk 7f6e853
add delete button and create wopi/setting route to handle wopi file r…
codewithvk 161c2d7
Manage setting configs files with dynamic routes
codewithvk 5faddca
Code cleanup: Remove POC helper functions
codewithvk 68a6e1a
Send WOPI setting base URL to integrator
codewithvk 5708c41
fix: fetch config url
codewithvk 344d6bc
wopi: add delete setting file route
codewithvk 09d0ad8
refactor: token generation for iframe
codewithvk d8ee942
feat(user-settings): introduce iframe for user settings
codewithvk 793f2cb
fix: linting issue for CI
codewithvk 67eb6a2
fix: generate token for user shared config url
codewithvk ac2a817
fix: accept document and setting url token for file upload
codewithvk 9368015
fix: set proper WOPI response and remove unnecessary WOPI callback fr…
codewithvk 5489b0f
fix(settings): remove iframe title and section
codewithvk fcccdb7
fix(settings): fetch directory from root folder
codewithvk 2abb0be
fix(wopi): share SharedSettings to wopi checkfileInfo
codewithvk 267bfd6
fix(wopi): Generating setting token for guest users
codewithvk b0042bd
fix(settings): generate user config per userId & handle guest users
codewithvk a01da14
fix: composer psalm error via pointing correct folder
codewithvk e7e3f09
fix: code cleanups
codewithvk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliusknorr As of now temporary I'm sending stamp as time but we need to pass here Category folders etag/stamp - May be we can create method inside settingsService but still we need fetch stamp from Folder/SimpleFolder or even Node. I try to test with Node etag it seems not updating is something updated in child.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a simple approach you could try the using getMTime which is probably enough, but I'm not entirely sure this propagates as well
If that doesn't we may need to manually update the etag whenever a file is added/updated/removed through richdocuments
The following code should work for that then:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for future reference, the reason the etag is not propagating directly is because we skip it in https://github.com/nextcloud/server/blob/41c53648ad18e3a94b6ba18ad0e6c7c09a520bd9/lib/private/Files/Storage/Common.php#L346 as in other cases we do not make use of that for anything in appdata or we have a separate mountpoint like for collectives where we can apply our own storage wrapper nextcloud/collectives@b54e6be but that won't work for the case here.