Ensure we have a clean db schema when migrating #4606
Merged
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
force-pushed
the
fix/migration-oc
branch
from
eded31d to
76783ae
Compare
juliusknorr
changed the title
blizzz
approved these changes
Mar 19, 2025
I understand the change includes dropping the data. |
juliusknorr
force-pushed
the
fix/migration-oc
branch
from
76783ae to
9013490
Compare
|
Turns out it does not, I added a preSchemaChange step to delete existing rows. |
Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
force-pushed
the
fix/migration-oc
branch
from
9013490 to
e6d9989
Compare
|
/backport to stable31 |
|
/backport to stable30 |
This was referenced Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content of the oc_richdocuments_wopi table is just temporary tokens, so in oder to ensure that the db schema matches if we install from old ownCloud versions, we can just drop and recreate the table.
This may be an issue because we did introduce new columns in the old database.xml file that was not properly covered in migration from the old project.
Note the migration/doctrine abstractions will actually not drop but change the schema as one step.
Can be tested also by dropping some tables and running
occ migrations:execute richdocuments 2060Date20200302131958manually.