Skip to content

Conversation

@elzody
Copy link
Contributor

@elzody elzody commented Mar 24, 2025

Summary

Introduces Pinia in an effort to organize the admin settings a bit instead of having everything in one massive component.

Screen Recording

Custom Fonts
admin-settongs-redesign-custom-fonts.mp4

TODO

  • Tests

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody elzody added the enhancement New feature or request label Mar 24, 2025
@elzody elzody self-assigned this Mar 24, 2025
@elzody elzody requested a review from juliusknorr as a code owner March 24, 2025 17:19
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Mar 24, 2025
@elzody elzody moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Office team Mar 24, 2025
@elzody elzody marked this pull request as draft March 24, 2025 17:22
@elzody elzody force-pushed the feat/admin-settings-pinia branch 2 times, most recently from fc82d0a to f24d64f Compare March 24, 2025 20:52
@elzody
Copy link
Contributor Author

elzody commented Apr 1, 2025

@juliusknorr Do you think we should ignore the remote font config warning for now? Didn't we discuss that, because we can have these configuration files of our own now, we can always ensure there is one?

@juliusknorr
Copy link
Member

Curently we cannot verify this anyways as it is a setting in coolwsd.xml and we cannot check that.

Mid-term collabora planned to remove this configuration option as far as I understood and pass over the fonts without any configuration required, so I'd say it is fine to ignore that, yes.

@elzody elzody force-pushed the feat/admin-settings-pinia branch from f24d64f to 6c9d5ad Compare April 1, 2025 22:12
@elzody
Copy link
Contributor Author

elzody commented Apr 1, 2025

@nextcloud/designers I have uploaded a screen recording, can I get a design review on this please? :)

@elzody elzody moved this from 🏗️ In progress to 👀 In review in 📝 Office team Apr 11, 2025
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say generally it's fine, but instead of the red trash button, a tertiary one (icon only) is enough?

Also @marcoambrosini @susnux what would be cool is a nice component for lists so this is consistent across Nextcloud. If we want to get fancy, this could be a grid/tiled view with font and font name below each other, sort of laid out like the tiles we use for the settings of Dashboard.

-->

<template>
<NcSettingsSection :name="t('richdocuments', 'Custom Fonts')"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<NcSettingsSection :name="t('richdocuments', 'Custom Fonts')"
<NcSettingsSection :name="t('richdocuments', 'Custom fonts')"

Detail: Should be sentence case, like below for "Available fonts"

data-cy="newFontInput"
@change="selectFile">

<table>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not use a table for this, generally tables are bad for a11y and especially in this case where you do not have a table header.

Instead it probably makes more sense to use a list for this, semantically, and style it like you want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, I really appreciate any a11y tips I can get!

@susnux
Copy link
Contributor

susnux commented Apr 14, 2025

what would be cool is a nice component for lists so this is consistent across Nextcloud. If we want to get fancy, this could be a grid/tiled view with font and font name below each other, sort of laid out like the tiles we use for the settings of Dashboard.

We already have NcListItem as a consistent component for list items. Probably can do a lot like this.
Also this is very specific not sure how often it would be reused, but of course possible to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

5 participants