fix(SecureView): node cannot be found when within groupfolder #5058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested changes
Oct 2, 2025
blizzz
force-pushed
the
fix/noid/deletion-in-groupfolder
branch
from
58908fd to
950d054
Compare
icewind1991
reviewed
Oct 2, 2025
lib/Storage/SecureViewWrapper.php
Outdated
Comment on lines
96
to
98
| if ($parent === '' || $parent === '.') { | ||
| throw new NotFoundException(sprintf('Could not find cache entry for path of %s within storage %s ', $path, $storage->getId())); | ||
| } |
Member
There was a problem hiding this comment.
I don't think is correct, I think that would then fail when trying to move a file to the root of a storage.
if ($parent === '.') {
$parent = '';
}should be enough to handle the edge case
Member
Author
There was a problem hiding this comment.
a move to user root worked in my test, but would not count out there are other scenarios 😁
Member
Author
There was a problem hiding this comment.
adjusted to your suggestions anyways
blizzz
force-pushed
the
fix/noid/deletion-in-groupfolder
branch
from
950d054 to
604420b
Compare
blizzz
force-pushed
the
fix/noid/deletion-in-groupfolder
branch
from
604420b to
eeeb83b
Compare
Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix/noid/deletion-in-groupfolder
branch
from
eeeb83b to
07cad90
Compare
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
come-nc
approved these changes
Oct 7, 2025
icewind1991
approved these changes
Oct 8, 2025
Member
|
Does this apply to v30 as well? @blizzz ? |
Member
Author
Nope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The node cannot be properly figured out when the affected file stems from within a groupfolder. But we can use the filecache entry instead.
TODO
PermissionManager::shouldWatermark()as it now accepts Node or ICacheEntry which makes it harder to work with. – refactor: untangle Node|ICacheEntry parameter in shouldWatermark #5074Checklist