Skip to content

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Jun 6, 2022

To Do

  • Fix focus border not visible in light mode
  • Remove bottom border style erroneously applied to the elements within the contact
    • This was likely meant to remove the border for the last contact in the list but the border will be preserved to improve scannability
  • Restore top contact action
  • Navigate to and activate other actions with the keyboard

Example

image

@Pytal Pytal added this to the Nextcloud 25 milestone Jun 6, 2022
@Pytal Pytal requested a review from a team June 6, 2022 19:30
@Pytal Pytal self-assigned this Jun 6, 2022
@Pytal Pytal requested review from PVince81, artonge and szaimen and removed request for a team June 6, 2022 19:30
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

PVince81 commented Jun 7, 2022

/compile amend /

@PVince81
Copy link
Member

PVince81 commented Jun 7, 2022

ah, actually this needs a rebase first @Pytal

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 7, 2022
@nextcloud-command nextcloud-command force-pushed the enh/a11y/keyboard-contacts-menu branch from 8c62b99 to ca963ad Compare June 7, 2022 14:08
@Pytal Pytal force-pushed the enh/a11y/keyboard-contacts-menu branch from ca963ad to c1054ea Compare June 7, 2022 16:57
@Pytal Pytal requested a review from artonge June 7, 2022 17:02
@Pytal Pytal merged commit b7089c2 into master Jun 8, 2022
@Pytal Pytal deleted the enh/a11y/keyboard-contacts-menu branch June 8, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: accessibility feature: contacts menu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants