chore: update workflows from templates #47439
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: skjnldsv <[email protected]>
susnux
reviewed
Aug 22, 2024
| with: | ||
| node-version: ${{ steps.package-engines-versions.outputs.nodeVersion }} | ||
| cache: npm | ||
|
|
||
| - name: Set up npm ${{ steps.package-engines-versions.outputs.npmVersion }} | ||
| run: npm i -g 'npm@${{ steps.package-engines-versions.outputs.npmVersion }}' | ||
|
|
||
There was a problem hiding this comment.
rather fix on org template, no?
susnux
reviewed
Aug 22, 2024
| @@ -146,7 +146,7 @@ jobs: | |||
| run: | | |||
| git add '${{ github.workspace }}${{ needs.init.outputs.git_path }}' | |||
| git commit --signoff -m 'chore(assets): Recompile assets' | |||
|
|
|||
There was a problem hiding this comment.
same as above, rather fix org template
|
Basically for server we use more customized templates so update is not that easy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated by the workflow dispatcher
Please check that there are no reverted changes before merging ⚠
See templates in https://github.com/nextcloud/.github