perf: Log requests using high amount of memory as warning #48738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
requested review from
nickvergessen,
a team,
icewind1991,
skjnldsv and
yemkareems
and removed request for
a team
nickvergessen
approved these changes
Oct 16, 2024
solracsf
reviewed
Oct 16, 2024
| register_shutdown_function(function () { | ||
| $memoryPeak = memory_get_peak_usage(); | ||
| if ($memoryPeak > 300_000_000) { | ||
| $message = 'Request used more than 300 MB of ram: ' . Util::humanFileSize($memoryPeak); |
There was a problem hiding this comment.
Suggested change
| $message = 'Request used more than 300 MB of ram: ' . Util::humanFileSize($memoryPeak); | |
| $message = 'Request used more than 300 MB of RAM: ' . Util::humanFileSize($memoryPeak); |
| if ($memoryPeak > 300_000_000) { | ||
| $message = 'Request used more than 300 MB of ram: ' . Util::humanFileSize($memoryPeak); | ||
| $logger = \OCP\Server::get(LoggerInterface::class); | ||
| $logger->warning($message, ['app' => 'core']); |
There was a problem hiding this comment.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help us finding candidates to optimize more easily.