Block sharing with selected groups.

[redblom]

• Resolves: Option to exclude native groups to share with for security perspective #49198

Summary

Continuation of PR #49217

Checklist

• Code is properly formatted
• Tests unit are included

[redblom]

Status: Fully functional
To exclude groups from sharing, as an admin, open Administration settings and navigate to Administration -> Sharing
Below the 'Allow sharing with groups' checkbox you can add/remove groups to exclude from sharing.
As a consequence these groups will not appear in the share dialog when searching for groups to share with.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[provokateurin]

Looks mostly fine to me, but you need to make cs-fixer happy.

[come-nc]

Looks fine, did not test.

Would be better to do the check in the hideFromCollaboration method on groups, as the method is part of OCP and could be used by other apps.

[redblom]

Looks fine, did not test.

Would be better to do the check in the hideFromCollaboration method on groups, as the method is part of OCP and could be used by other apps.

Please correct me if I'm wrong but as far as I can tell the IHideFromCollaborationBackend isn't implemented anywhere and $group->hideFromCollaboration() currently always returns false.
So perhaps leave this for now (with a comment) until that implementation has been done, or at least implement that in another PR. What do you think?

[susnux]

Please correct me if I'm wrong but as far as I can tell the IHideFromCollaborationBackend isn't implemented anywhere and $group->hideFromCollaboration() currently always returns false.

You can add your code (the check of the config option) inside of hideFromCollaboration:

server/lib/private/Group/Group.php

Line 378 in 4f50b5f

public function hideFromCollaboration(): bool {

Here you would add it like:

  public function hideFromCollaboration(): bool {
+ 	$groupsBlockList = $this->appConfig->getValueArray('core', 'shareapi_groups_block_list', []);
- 	return array_reduce($this->backends, function (bool $hide, GroupInterface $backend) {
+ 	return in_array($this->gid, $groupsBlockList)
+ 		|| array_reduce($this->backends, function (bool $hide, GroupInterface $backend) {

[come-nc]

Looks fine, did not test.
Would be better to do the check in the hideFromCollaboration method on groups, as the method is part of OCP and could be used by other apps.

Please correct me if I'm wrong but as far as I can tell the IHideFromCollaborationBackend isn't implemented anywhere and $group->hideFromCollaboration() currently always returns false. So perhaps leave this for now (with a comment) until that implementation has been done, or at least implement that in another PR. What do you think?

I do not know about the backends, but in this case you do not care about the backend you can implement that directly in nextcloud/server/lib/private/Group/Group.php
It’s always this class that represents a group, whatever its backend.

[provokateurin]

I only have a few small remarks, the approach and logic looks good to me!

[provokateurin]

Thanks a lot, this looks really nice now!

[redblom]

@provokateurin

Still some meaningless changes here.

Right I see, that's coming from the cs-fix. But I reverted it.

[provokateurin]

Can you squash the commits? Your commit message will also have to follow https://www.conventionalcommits.org/en/v1.0.0/ to pass CI.

[susnux]

Tests need to be adjusted:

1. Test\Group\GroupTest::testGetUsersSingleBackend
   ArgumentCountError: Too few arguments to function OC\Group\Group::__construct(), 4 passed in /home/runner/actions-runner/_work/server/server/tests/lib/Group/GroupTest.php on line 68 and at least 5 expected

/home/runner/actions-runner/_work/server/server/lib/private/Group/Group.php:55
/home/runner/actions-runner/_work/server/server/tests/lib/Group/GroupTest.php:68