Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore : Improved testing and feature enhancements for public sharing #50260

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Jan 18, 2025

This update enhances the testing framework for public sharing by improving the setup and management of share contexts. It refactors the code to make the createShare function reusable externally, ensuring better testability and flexibility. Additionally, the update optimizes share permission adjustments and improves state management, making public share setups more efficient and maintainable.

Adds the following tests:

  • Checks if user can see enforced expiry date before link share is created
  • Checks if user can see non-enforced default expiry before share is created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant