Fix/calendar reminders

[matthias480]

• Resolves: [Bug]: Calendar reminders not being sent if group name has special characters #41203

Summary

Following problems are fixed:

• The Groupware setting "Send reminder notifications to calendar sharees as well" (sendEventRemindersToSharedUsers) behaved exactly the other way round.
  If it was activated, sharees din't receive a notification.
• Members of groups with names that contain special characters (also spaces) didn't receive notifications.
• Calendar principal user received reminder notification twice if he/she was also a sharee (emails not affected as EmailProvider filters duplicates)

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[matthias480]

/backport to stable31

[matthias480]

/backport to stable30

[matthias480]

/backport to stable29

[SebastianKrupinski]

Hi @matthias480

Thank you for the PR. I will test/review it when I get a min.

But I have some initial comments,

A. What is the best way to test this, can you give me a short step by step.
B. Once the changes are approved I will need to recreate this PR as our CI will not run properly on forked PR's
C. We will only backport this back to 29 as our policy is 3 version for backport unless they are security fixes.

[matthias480]

Hi @SebastianKrupinski

Thank you!

B. OK. I made a fork, because I had no permission to push my branch.
C. OK, I removed 28 and 27.
A. How to test:

Preparation:

• Have at least 3 users with email addresses.
• Configure your instance to be able to send emails.
• Enable Groupware setting "Send notifications for events".
• Run php occ config:app:set dav sendEventRemindersMode --value occ in order to make sending of event reminders triggerable via occ command

Issue 1:

1. Create new calendar with user 1.
2. Share calendar with user 2 (write access).
3. Enable Groupware setting "Send reminder notifications to calendar sharees as well".
4. Create new event with one email reminder and one notification reminder.
5. Save the event.
6. Trigger sending when reminders are due via php occ dav:send-event-reminders.
7. Observe:
   • Without this PR:
     • User 1 receives reminder mail and notification.
     • User 2 doesn't receive any reminder although "Send reminder notifications to calendar sharees as well" is enabled.
   • With this PR:
     • User 1 and user 2 receive reminder mail and notification.
8. Disable Groupware setting "Send reminder notifications to calendar sharees as well".
9. Repeat 4-6
10. Observe:
    • Without this PR:
      • User 1 receives reminder mail and notification.
      • User 2 receives reminder mail and notification although "Send reminder notifications to calendar sharees as well" is disabled.
    • With this PR:
      • User 1 receives reminder mail and notification.
      • User 2 doesn't receive any reminder.

Issue 2 + 3:

1. Create new group with name "Group1".
2. Create new group with name "Group Two".
3. Add user 1 and user 3 to "Group1", add user 2 to "Group Two".
4. Create new calendar with user 1.
5. Share calendar with both groups (write access).
6. Enable Groupware setting "Send reminder notifications to calendar sharees as well". Without this PR: Disable setting since the behavior is the opposite..
7. Create new event with one email reminder and one notification reminder.
8. Save the event.
9. Trigger sending when reminders are due via php occ dav:send-event-reminders.
10. Observe:
    • Without this PR:
      • User 1 receives two notifications (because he is the owner/principal and member of Group1) and one mail (mail duplicates are filtered in EmailProvider).
      • User 2 doesn't receive any reminder because group name contains special character (space).
      • User 3 receives reminder mail and notification because group name doesn't contain special characters.
    • With this PR:
      • User 1, 2 and 3 receive one notification and one reminder mail.

Remark: I tested with cron instead of php occ dav:send-event-reminders.

[SebastianKrupinski]

Hi @matthias480

Thank you for the very thoroughly step by step, it make it easier for us to reproduce the issues and test the fixes.

Please give me a few days to test this.

[matthias480]

Hi @SebastianKrupinski

Not really the preferred way, but since it is in the same file, I added another commit in this PR with two small improvements. I hope, that's OK.

• Added the From name in the reminder email (analogous to other system mails)
• Localized the email's subject (currently it's hard-coded: "Notification:")
  • Actually I would prefer "Reminder:" but I didn't want to touch the current state

[SebastianKrupinski]

Hi @matthias480

Thank you, I have not had a chance to test this yet, but will review it test it this week.

[niklaswolf]

The Groupware setting "Send reminder notifications to calendar sharees as well" (sendEventRemindersToSharedUsers) behaved exactly the other way round.
If it was activated, sharees din't receive a notification.

I came to the exact same conclusion debugging this on my own, so I confirm the fix for this 👍

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)