-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(occ): add json output option to admin-delegation:show #51124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(occ): add json output option to admin-delegation:show #51124
Conversation
73bf32a
to
cfb7568
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only one comment about code duplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise
Signed-off-by: Kent Delante <[email protected]>
Signed-off-by: Kent Delante <[email protected]>
Signed-off-by: Kent Delante <[email protected]>
cfb7568
to
1be410c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have let the getDelegatedSettings
block at the bottom to reduce the diff, but looks good anyway.
Thanks for the tip. I'll keep that in mind next time. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Add option to output json with admin-delegation:show using --output=json or --output=json_pretty
Example Output (plain json):
Example Output (pretty json):
Checklist