Skip to content

refactor(account-management): Separate group views from internal views #51465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 13, 2025

Summary

Some refactoring of the route handling for the account management. We separate internal views like disabled or recent accounts from group views like admin or custom-group-id.

The new URL looks like:
/settings/users/VIEW(/GROUP) for example a real group like admin has this new URL: /settings/users/group/admin.
While internal views like recent users look like: /settings/users/recent.

Checklist

Some refactoring of the route handling for the account management.
We separate internal views like *disabled* or *recent* accounts from
group views like *admin* or *custom-group-id*.

The new URL looks like:
`/settings/users/VIEW(/GROUP)` for example a real group like `admin` has
this new URL: `/settings/users/group/admin`.
While internal views like *recent* users look like:
`/settings/users/recent`.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux added 3. to review Waiting for reviews feature: users and groups ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Mar 13, 2025
@susnux susnux added this to the Nextcloud 32 milestone Mar 13, 2025
@susnux susnux requested a review from a team as a code owner March 13, 2025 15:49
@susnux susnux requested review from skjnldsv, szaimen, sorbaugh and Pytal and removed request for a team and sorbaugh March 13, 2025 15:49
@kesselb
Copy link
Contributor

kesselb commented Mar 13, 2025

Thanks for picking it up 🙏

  1. I've run into an issue with the password confirmation modal. Tip: Change nc_lastLogin to 0 in JSConfigHelper.php to always see the password confirmation request.

image

  1. Probably out of scope, but if you create a group called "disabled", then the group is still not visible, but the disabled section is also gone 🤷

@susnux
Copy link
Contributor Author

susnux commented Mar 13, 2025

@kesselb

  1. is unrelated - best report this in https://github.com/nextcloud-libraries/nextcloud-password-confirmation/issues
  2. this one I would fix here. Lets see whats going on there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: users and groups ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird URL for accounts -> recently active
2 participants