fix: ensure all object store configuration have distict bucket names #54920
+31
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable32 |
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
object-store-unique-buckets-names
branch
from
e4f6b7c to
0c1d5e8
Compare
provokateurin
approved these changes
Sep 5, 2025
come-nc
approved these changes
Sep 8, 2025
Member
Author
|
Included in #56557 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the bucket name is used as the main determinant for the storage id (and changing this would be complicated). Having different object store configuration with the same bucket name would lead to complications.
So we just ensure that all configurations have a distinct bucket name.