fix(workflow): Fix icon colors in settings#55271
Draft
nickvergessen wants to merge 1 commit intomasterfrom
Draft
fix(workflow): Fix icon colors in settings#55271nickvergessen wants to merge 1 commit intomasterfrom
nickvergessen wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
nfebe,
susnux and
szaimen
and removed request for
a team
nickvergessen
added
bug
3. to review
jancborchardt
requested changes
Sep 23, 2025
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
As per the WebAIM color contrast checker, that red background needs white foreground, and that green background needs black foreground.
https://webaim.org/resources/contrastchecker/
Contributor
|
IMHO just use the proper |
Member
Author
|
Those are not supposed to be limited to those few variables. But for now we will keep it broken and then consider using a stripe like on the talk dashboard going forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's arguable whether the icon+text should be white in all cases, similar to the old screenshot on https://github.com/nextcloud/files_accesscontrol?tab=readme-ov-file#how-it-works
But at least both should be same. cc @jancborchardt
Checklist
3. to review, feature component)stable32)