refactor(dav): Clean up QuotaPlugin and add new hints #55293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new hints and improve documentation for the QuotaPlugin. This commit also removes unused code and tidies up some code, which improves readability and simplifies maintenance, without introducing breaking changes. Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
Tagged with \@internal instead for now. Signed-off-by: Josh <[email protected]>
Doesn't match current interface. Signed-off-by: Josh <[email protected]>
Updated the buildFileViewMock method to accept int, float, or false as quota type. Signed-off-by: Josh <[email protected]>
joshtrichards
requested review from
ArtificialOwl,
icewind1991,
skjnldsv and
sorbaugh
and removed request for
a team
Co-authored-by: Carl Schwan <[email protected]> Signed-off-by: Josh <[email protected]>
Co-authored-by: Carl Schwan <[email protected]> Signed-off-by: Josh <[email protected]>
joshtrichards
added
♻️ refactor
Signed-off-by: Josh <[email protected]>
Signed-off-by: Josh <[email protected]>
icewind1991
reviewed
Sep 30, 2025
| } | ||
| // Explicitly handle unknown/invalid free space | ||
| if ($freeSpace === false || $freeSpace < 0) { | ||
| // You might log here; currently allows the operation |
Member
There was a problem hiding this comment.
no need to log here as this is fully expected
icewind1991
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These changes improve readability and simplify maintenance, without introducing breaking changes.
TODO
Checklist
3. to review, feature component)stable32)