feat(TaskProcessing): user-facing error messages #55713
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
…r messages Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
kyteinsky
reviewed
Oct 13, 2025
| * @throws Exception If the query failed | ||
| * @throws NotFoundException If the task could not be found | ||
| * @since 30.0.0 | ||
| * @aince 33.0.0 Added `userFacingError` parameter |
There was a problem hiding this comment.
Suggested change
| * @aince 33.0.0 Added `userFacingError` parameter | |
| * @since 33.0.0 Added `userFacingError` parameter |
Comment on lines
+1102
to
+1103
| // truncate error message to 1000 characters | ||
| $task->setUserFacingErrorMessage(mb_substr($userFacingError, 0, 1000)); |
There was a problem hiding this comment.
the db max length says 4000. I don't remember but was it because of the multibyte string partition?
There was a problem hiding this comment.
yes, we usually use utf8_mb4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the task processing API only had internal error messages that are not safe to show to the user. This PR extends it so that providers can also set user-facing error messages.
Checklist
3. to review, feature component)stable32)