Skip to content

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Oct 13, 2025

  • Resolves: #na

Summary

  • Removes no longer needed legacy fallback (used only for v19->v20; was added in Fix undefined class property access after upgrade from 19 to 20 #22641).
  • Explicitly handles JSON decode failures.
  • Includes minor readability improvements, such as splitting out session fallback (non-legacy) into a dedicated function.
  • Updates docblocks.
  • Adds clearer exception messages

Outside of dropping the no longer applicable v19 legacy fallback behavior, there should be no breaking changes here. Other changes are purely code readability (e.g. re-ordering, separation of concerns, adjusting logic to not need temporary flag variable, minimize nesting, short/focused docblocks).

TODO

  • Have to finish adjusting the unit tests

Checklist

…e clarity

Removes no longer needed legacy fallback (used only for v19->v20).

Explicitly handles JSON decode failures.

Includes minor readability improvements, such as splitting out session fallback (non-legacy) into a dedicated function.

Updates and streamlines docblocks.

Signed-off-by: Josh <[email protected]>
@joshtrichards joshtrichards added enhancement 3. to review Waiting for reviews feature: authentication ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress enhancement feature: authentication ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant